Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(breadbox): Remove catalog node aliases #10

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

snwessel
Copy link
Member

@snwessel snwessel commented Jul 22, 2024

Asana

This PR removes the remaining references to "aliases" which were originally supported using CatalogNodes. This is another small step in the direction of removing CatalogNodes altogether.

The only actual API change is that the UploadDatasetResponse no longer has a sliceId. That fields value was set to the dataset catalog node's id, and it was only being used by the old version of Elara.

@snwessel snwessel requested a review from pgm July 23, 2024 13:56
Copy link
Contributor

@pgm pgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snwessel snwessel merged commit 1418f65 into master Jul 23, 2024
26 checks passed
@snwessel snwessel deleted the bb-remove-catalog-node-aliases branch July 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants